spajak / cef-pdf

cef-pdf HTML to PDF utility
MIT License
77 stars 33 forks source link

errors for invalid cli flag calls or more forgiving syntax #2

Closed ghost closed 6 years ago

ghost commented 6 years ago

Thanks for building this tool. It looks much more promising and reliable than other html to pdf binaries/libraries I have worked with. I have been using it successfully so far but accidentally typed:

 $ src/Release/cef-pdf.app/Contents/MacOS/cef-pdf --file ./test.html ./test.pdf

Instead of erroring, the binary unexpectedly overwrite test.html. It would be nice if the cli threw an error that I mistyped the --file switch, or was a tad more flexible.

spajak commented 6 years ago

Thanks for pointing this out. Already fixed in devel branch

ghost commented 6 years ago

ah, thanks @spajak ! will close this then