search

spajak / cef-pdf

cef-pdf HTML to PDF utility
MIT License
79 stars 32 forks source link

Removed buggy helper func insertion, abort remote trigger if not registered sync on load. #22

Closed beckyconning closed 6 years ago

beckyconning commented 6 years ago

This aborts generations started with remote trigger enabled if the page doesn't evaluate

window.cefPdfQuery({request: "register", onSuccess: function () {}, onFailure: function () {}});

synchronously during load.

this can be achieved by adding the following script tag to the body.

<script>window.cefPdfQuery({request: "register", onSuccess: function () {}, onFailure: function () {}});</script>

Helper functions are also removed for now until they can be inserted into the window object deterministically before load start.

Will update the readme in a second.

Fixes #6 Fixes #20

beckyconning commented 6 years ago

Readme updated. @spajak @anko please review : )

beckyconning commented 6 years ago

Sorry forgot to update the help stuff in main. Done now. Please review : )

beckyconning commented 6 years ago

How strange, just having a meeting with a contractor now on how to fix your segfaults and you reject my PRs containing crucial features.

spajak commented 6 years ago

Please create a separate fork for this feature

beckyconning commented 6 years ago

Will do.