search

spajak / cef-pdf

cef-pdf HTML to PDF utility
MIT License
77 stars 33 forks source link

ignore auto generated files #4

Closed ghost closed 6 years ago

ghost commented 6 years ago

I also noticed the following files in my working directory upon compiling:

libcef_dll_wrapper/
src/Release/

I think these should be added as well to the .gitignore?

spajak commented 6 years ago

You should always build outside source directory. Maybe Cmake rule to disallow building in source dir would be more appropriate?

ghost commented 6 years ago

ah, I see @spajak . Yes, when you get a chance, I think that would be great.