search

spajak / cef-pdf

cef-pdf HTML to PDF utility
MIT License
79 stars 32 forks source link

http server broken in last release. #9

Closed beckyconning closed 7 years ago

beckyconning commented 7 years ago

curl -X POST http://localhost:9288/timeout.pdf --header "Content-Location: http://www.google.com" > output.pdf

works on 0.3.1 but hangs forever on 0.3.2 and master

beckyconning commented 7 years ago

It might be worth adding some curl / diff based tests to prevent such regressions in the future?

spajak commented 7 years ago

Preparing fix for this. That would be a good idea to add some tests

spajak commented 7 years ago

Fixed in devel branch. Please test it if you can

beckyconning commented 7 years ago

Will do first thing tomorrow. Thanks so much!

beckyconning commented 7 years ago

Yup works for me! Happy to close when its been released : ).

beckyconning commented 7 years ago

When is the fix for this going to be merged into master / released?

spajak commented 7 years ago

I think tomorrow or Sunday

spajak commented 7 years ago

Closing