Closed Slayer95 closed 9 years ago
@Slayer95 the "current" build is just the latest build of this pr
The badge on the repo is filtered to the master branch
Actually, the Current
tab displays a different commit with a minimal delta that I pushed to this branch earlier: https://github.com/spalger/gulp-jshint/commit/5e989cccc6d7e43ffe99465e292f022cd991b56d
And it also fails the build. https://travis-ci.org/spalger/gulp-jshint/jobs/65357850
Running gulp test
locally also fails before this commit.
Probably the passing
result is simply a cache from a previous sucessful build?
hmm, tests run fine for me. What failure do you get?
npm version
, npm ls
, and gulp test
:
http://hastebin.com/orilofegih.tex
This patch fixes the failing tests for me, but it may or may not be the ideal fix
Both failing tests pass on reversion to JSHint 2.7.0. Apparently, from 2.7.0 to 2.8.0 the errors and warnings change for the analyzed fixtures.
jshint@2.8.0 E2 W0 I0 E4 W0 I0
jshint@2.7.0 E2 W2 I0 E4 W4 I0
It looks like https://github.com/spalger/gulp-jshint/commit/ad8ce6043aee3d045c1c059d079ffcb24d8b203e passed the tests due to pure chance. https://github.com/spalger/gulp-jshint/pull/114 fixes this.
Rebased and it passes now! :]
Thanks @Slayer95 :)
@spalger, the build for the current version of the package is failing (which is odd since the badge in the readme displays "passing"). Maybe some dependency update broke it?