Remove potential Unicode BOM

spalger / gulp-jshint

JSHint plugin for gulp

MIT License

419 stars 65 forks source link

Remove potential Unicode BOM #65

Closed akkumanova closed 10 years ago

akkumanova commented 10 years ago

This pull request strips potential unicode BOM from the files before passing it to jshint as jshint cli does (link to code) and as suggested by nodejs developers (link). This is needed because some text editors insist on setting the BOM (e.g. Visual Studio).

spalger commented 10 years ago

Awesome, thanks @akkumanova.

yocontra commented 10 years ago

gulp has been removing the BOM for months, this commit will just slow stuff down since the BOM is already removed. See https://github.com/wearefractal/vinyl-fs/pull/21 - I would recommend reverting this

spalger commented 10 years ago

Interesting. Thank you @contra