search

spalger / gulp-jshint

JSHint plugin for gulp
MIT License
419 stars 65 forks source link

options.globals get overridden inside gulp-jshint #95

Open nadavsr opened 9 years ago

nadavsr commented 9 years ago

Looks like bug #21 is back after rcloader has been upgraded from 0.1.2 to 0.1.4.

I can confirm that v1.9.1 of gulp-jshint works fine with rcloader v0.1.2.

It looks like the cloning of the configuration that fixed bug #21 has been removed in a subsequent commit - could this be returned?

xavimb commented 9 years ago

+1 to this problem

doberkofler commented 9 years ago

+1 (all my build are no longer working after updating)

shellscape commented 9 years ago

:+1: same problem here.

This line is the culprit https://github.com/spenceralger/gulp-jshint/blob/master/src/lint.js#L41

@spenceralger not indenting to be rude or rush, but is there an ETA on a fix? we're going to manually downgrade for the time being. just curious on when to check back on it.

maccurt commented 9 years ago

All my build broke too, I am going to go back to 1.9.0 for the time being, it seems as if it does not recognize my global suppression config anymore

doberkofler commented 9 years ago

moving back to 1.9.0 did not work for either.

maccurt commented 9 years ago

Yipe you are right moving back to 1.9.0 did not work for me, it has something perhaps to do with the upgrade of rcloader, my build was working with 0.1.2 . gulp-jshint has a dependecy on lodash, minimatch, and some others.. but right now perhaps it is rcloader 0.1.4

spalger commented 9 years ago

Working on it, fix inbound

maccurt commented 9 years ago

Thanks for working on it, disregard my email I sent you please..

spalger commented 9 years ago

Well, not sure exactly what happened but I have published 1.9.2 locked to rcloader 0.1.2.

rcloader 0.1.4 seems to mutate the config somehow but I don't have the bandwidth to track down the issue right now. Can someone confirm this fixes the issue for now?

Tests are passing and more need to be written to prevent this issue from coming back down the road. Can someone submit code that fails in 1.9.1 but passes in 1.9.2?

Thanks for your patience :smiley:

maccurt commented 9 years ago

Thanks for doing that so quick. That fixed my issue

doberkofler commented 9 years ago

1.9.2 fixed my issues.

The following example failed in 1.9.1 and works again in 1.9.2.:

/*jshint node:true*/
console.log(_.isObject({}));
{
    "globals": {
        "_": false
    }
}