search

spalger / gulp-jshint

JSHint plugin for gulp
MIT License
419 stars 65 forks source link

Added ability to configure the stream #97

Open ericjperry opened 9 years ago

ericjperry commented 9 years ago

Needed the ability to control the stream timeout, so I added in the stream configuration to the gulp-jshint exported function.

Slayer95 commented 9 years ago

@spalger, any interest in merging this or an equivalent feature?

talberto-zz commented 9 years ago

+1 for this PR. As mentioned in #88, the stream timeout isn't configurable. It's just a matter of correctly passing the opt parameter to the stream function. Any chance this PR will be merged any time soon?

spalger commented 9 years ago

@Slayer95 @talberto honestly I would accept a PR to remove the timeout stuff from the stream module if you're up for it.

I'm not a fan of the API implemented here, and the timeout was really just designed as a backup. I don't think there's any reason to leave it in any more.