spamhaus / rspamd-dqs

Spamhaus code for RSPAMD Plugin. See https://docs.spamhaustech.com/40-real-world-usage/Rspamd/000-intro.html for instructions
Apache License 2.0
60 stars 11 forks source link

`rspamd.local.lua` is a common filename for other services... there is danger of overwriting an existing config #20

Open GwynethLlewelyn opened 1 year ago

GwynethLlewelyn commented 1 year ago

Hi there,

First of all, thanks for your amazing spam blocking service, and the many ways you guys provide to integrate with it :-)

I've noticed that unfortunately there are more providers, beyond SpamHaus, that use rspamd.local.lua to store their rules. I noticed that in the worst possible way, i.e. copying the rules as per instructions on the README... overwriting what I already had :-)

Fortunately I had backups, of course, but it might be nice to add a line just to give fair warning about the possibility of pre-existing files with the same name; the reverse is of course also true, people should pay close attention when using other services that also have a rspamd.local.lua file, lest they overwrite the SpamHaus configuration!

The alternative, of course, would be to add a file with a unique name, e.g. rspamd-spamhaus.local.lua, but I suspect this would require a bit more tweaking elsewhere...