search

spamhaus / spamassassin-dqs

Spamhaus code for the Spamassassin plugin. See https://docs.spamhaustech.com/40-real-world-usage/SpamAssassin/000-intro.html
Apache License 2.0
54 stars 16 forks source link

Unnecessary List::MoreUtils #2

Closed hege-li closed 5 years ago

hege-li commented 5 years ago

I suggest removing the completely unnecessary and superficial dependency of List::MoreUtils, and instead use the "ancient" method of hashing:

my %emails; while (...) { ... $emails{$foo} = 1; ... } my @uniq_emails = keys %emails;

ricalfieri commented 5 years ago

Would you mind submitting a patch or a merge request?

hege-li commented 5 years ago

I leave this up to you since it's trivial really, I try to direct my free hobby work time directly into SpamAssassin.

ricalfieri commented 5 years ago

Done, prerequisite removed