search

spamhaus / spamassassin-dqs

Spamhaus code for the Spamassassin plugin. See https://docs.spamhaustech.com/40-real-world-usage/SpamAssassin/000-intro.html
Apache License 2.0
54 stars 15 forks source link

Avoid duplicated lookups by using zen instead of sbl-xbl #28

Closed robertmathews closed 3 years ago

robertmathews commented 3 years ago

I noticed that the plugin often makes otherwise-identical queries to both "zen.dq.spamhaus.net" and "sbl-xbl.dq.spamhaus.net". Some of the rules explicitly mention sbl-xbl, but that seems unnecessary. Replacing those with zen avoids duplicate lookups.

Before this change, a SpamAssassin debug log would often show something like:

async: launching A/1.113.0.203.key.zen.dq.spamhaus.net for DNSBL:1.113.0.203:key.zen.dq.spamhaus.net async: launching A/1.113.0.203.key.sbl-xbl.dq.spamhaus.net for SH:1.113.0.203.key.sbl-xbl.dq.spamhaus.net

With this change, it only does the first of these. The results otherwise seem identical.

ricalfieri commented 3 years ago

Good catch, thanks