Closed robertmathews closed 3 years ago
Are you using the latest version? Because in my version the function is:
my $skip_domains = $conf->{sh_emailbl_skip_domains};
So it's using a dedicated config directive, not uridnsbl_skip_domain
I just tried with a sample with a listed @gmail.com address and it works as expected
You're right, I misunderstood the code, and then did an invalid test that made it look like it was failing when it isn't. I'll close this; sorry for the noise.
Don't worry, any feedback is appreciated :)
The code for
check_sh_emails
currently skips an HBL lookup if the domain name is in skip_domains (uridnsbl_skip_domain).So, for example, if
gmail.com
is in skip_domains (as it is by default), it won't do an HBL lookup on the hash forevildoer@gmail.com
.It obviously makes sense to not do DBL lookups for skip_domains, but HBL seems different: my understanding is that it might contain the hash for
evildoer@gmail.com
even ifgmail.com
would never be in the DBL. If that's the case,if (!($skip_domains->{$this_domain}))
check should probably be removed fromcheck_sh_emails
.