search

spamhaus / spamassassin-dqs

Spamhaus code for the Spamassassin plugin. See https://docs.spamhaustech.com/40-real-world-usage/SpamAssassin/000-intro.html
Apache License 2.0
54 stars 15 forks source link

Regular expressions without '$'? #46

Closed robert-scheck closed 2 years ago

robert-scheck commented 2 years ago

Is it really intended that the following regular expressions are without a terminating $?

https://github.com/spamhaus/spamassassin-dqs/blob/4d086846defc10f6535f9b656274a139cbe0126e/sh.cf#L73 https://github.com/spamhaus/spamassassin-dqs/blob/4d086846defc10f6535f9b656274a139cbe0126e/sh.cf#L77 https://github.com/spamhaus/spamassassin-dqs/blob/4d086846defc10f6535f9b656274a139cbe0126e/sh.cf#L81 https://github.com/spamhaus/spamassassin-dqs/blob/4d086846defc10f6535f9b656274a139cbe0126e/sh.cf#L85

As of writing, not only a returned 127.0.0.2 would be matched by the first expression, but also e.g. a returned 127.0.0.255. And even if that behaviour is intended, all other rules do handle possible replies explicitly rather implicitly.

ricalfieri commented 2 years ago

You are correct and those regexes are now fixed