search

spamhaus / spamassassin-dqs

Spamhaus code for the Spamassassin plugin. See https://docs.spamhaustech.com/40-real-world-usage/SpamAssassin/000-intro.html
Apache License 2.0
54 stars 15 forks source link

Replace rdatastr with rdstring #60

Closed marcbradshaw closed 10 months ago

marcbradshaw commented 1 year ago

Within Net::DNS rdatastr has been deprecated, and replaced with rdstring. This is giving a warning when used with the latest Net::DNS

ricalfieri commented 1 year ago

Hello. Did you test this on SA 3.4.1? Asking this because I don't know if rdstring is available with older distributions and I don't want to break backward compatibility.

marcbradshaw commented 1 year ago

Hi, this reflects a change in Net::DNS rather than in Spamassassin. The deprecation warning starts in Net::DNS version 1.38 (May 9, 2023) The change to introduce the rdstring method was made in late 2012, in the release 0.69 (released Dec 05 2012)

ricalfieri commented 10 months ago

Being this a fix for the 3.4.x branch, and taking in account that we have multiple customers using ancient versions of SA/Perl , I think it's not a good idea to merge the changes for this branch and risk causing problems to them. Best thing to do is move to the supported 4.x branch