search

spamhaus / spamassassin-dqs

Spamhaus code for the Spamassassin plugin. See https://docs.spamhaustech.com/40-real-world-usage/SpamAssassin/000-intro.html
Apache License 2.0
54 stars 15 forks source link

SH_BODYURI_REVERSE_SBL uses check_sh_bodyuri_a() uses non-working uridnsbl_skip_domains #69

Open robert-scheck opened 6 months ago

robert-scheck commented 6 months ago

Moving https://github.com/spamhaus/spamassassin-dqs/issues/68#issuecomment-1934025891 as kindly requested by @xrat in https://github.com/spamhaus/spamassassin-dqs/issues/68#issuecomment-1934167722 into an own issue:

https://github.com/spamhaus/spamassassin-dqs/blob/666784cf94d8d17e3e2ffc09e95116aad5246af4/3.4.1%2B/SH.pm#L707

does not work, @ricalfieri. SH_BODYURI_REVERSE_SBL uses check_sh_bodyuri_a() which aims to use a skip list via

https://github.com/spamhaus/spamassassin-dqs/blob/666784cf94d8d17e3e2ffc09e95116aad5246af4/3.4.1%2B/SH.pm#L697

which suggests to be filled using uridnsbl_skip_domains, which however unfortunately has absolutely no effect (it's actually uridnsbl_skip_domain googleapis.com fonts.googleapis.com in my SpamAssassin configuration). My expectation is quite simply: Please really skip the domain as the SH.pm code makes admins believe.

ricalfieri commented 6 months ago

Hello, i'm not going to fix something on 3.4.x. If anyone wants to make a pull request with a fix it would be appreciated