Make re2 an optional peer dependency

spamscanner / url-regex-safe

Regular expression matching for URL's. Maintained, safe, and browser-friendly version of url-regex. Resolves CVE-2020-7661 for Node.js servers.

https://forwardemail.net/docs/url-regex-javascript-node-js

MIT License

79 stars 16 forks source link

Make re2 an optional peer dependency #24

Closed KevinNovak closed 2 years ago

KevinNovak commented 2 years ago

Address issue #23. This is basically Option 1 in #18.

KevinNovak commented 2 years ago

Looks like some of the scripts, like the "test-coverage" script run by the CI, requires re2 to be installed. Not sure the best action to take here. Should we require re2 for tests but not for the overall package?

niftylettuce commented 2 years ago

Add re2 to devDependencies

niftylettuce commented 2 years ago

I'll manually add it and version bump and fix lockfile.

niftylettuce commented 2 years ago

See v3.0.0 https://github.com/spamscanner/url-regex-safe/releases/tag/v3.0.0