fix: don't match a trailing period after the path

birtles commented 11 months ago

Fixes #17.

This also extends trailingPeriod: false (the default) to exclude matching a trailing question mark (?) or exclamation mark (!).

That is if you want "Check out example.com/project." to NOT match the trailing period, you typically also want it to NOT match the trailing exclamation mark in "Check out example.com/project!". Likewise for "Have you seen example.com/project?".

I guess technically trailingPeriod should be renamed trailingPunctuation but maybe it's fine as-is?

Checklist

[x] I have ensured my pull request is not behind the main or master branch of the original repository.
[x] I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
[x] I have written a commit message that passes commitlint linting.
[x] I have ensured that my code changes pass linting tests.
[x] I have ensured that my code changes pass unit tests.
[x] I have described my pull request and the reasons for code changes along with context if necessary.

titanism commented 11 months ago

Amazing work! 🙏 Thank you!

titanism commented 11 months ago

Publishing now, one moment

titanism commented 11 months ago

v4.0.0 released with this, thank you @birtles

release notes @ https://github.com/spamscanner/url-regex-safe/releases/tag/v4.0.0

note: this version now requires node v14+

spamscanner / url-regex-safe

fix: don't match a trailing period after the path #29

Checklist