spamwax / alfred-pinboard-rs

Alfred Workflow for Pinboard (Rust)
Other
277 stars 13 forks source link

Search function for Korean language does not work. #138

Closed cloudshand closed 2 years ago

cloudshand commented 2 years ago

'ps 한글' does not work.

spamwax commented 2 years ago

I am kinda of surprised. Can you please provide more info:

If you can, enable the debug option of workflow in Alfred and then use the search term. Then post the output in the debug window here please.

This is interesting since, in my tests we can handle non-english URLs!

cloudshand commented 2 years ago

On a Mac, pins works just fine. In Alfred workflow, English works fine, but Korean doesn't search. Refer to the screenshots. Korean word “쉐우민"

      1. 오후 10:20, spamwax @.***> 작성:

I am kinda of surprised. Can you please provide more info:

what is the bookmark that has the korean word? is it in url, title, tags or description of bookmark? would you mind sharing it? what is the keyboard layout/standard you are using? what is the "Preferred languages" in System Preferences -> Language and Region? If you can, enable the debug option of workflow in Alfred and the use the search term. Then share the output in the debug window please?

This is interesting since, in my tests https://github.com/spamwax/rusty-pin/blob/26109a38817ae4ad76d7781affc9aae5f919ac78/src/pinboard/api.rs?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L351 we can handle non-english URLs!

— Reply to this email directly, view it on GitHub https://github.com/spamwax/alfred-pinboard-rs/issues/138#issuecomment-1004086766, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNF6ENJYFOZD4IAZ5FPFTTUUGPADANCNFSM5LET6GJQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.

spamwax commented 2 years ago

I don't see any screenshots :)

cloudshand commented 2 years ago

https://www.craft.do/s/ziC267GFIQgjSU

      1. 오전 9:34, 이기남 @.***> 작성:

On a Mac, pins works just fine. In Alfred workflow, English works fine, but Korean doesn't search. Refer to the screenshots. Korean word “쉐우민"

      1. 오후 10:20, spamwax @. @.>> 작성:

I am kinda of surprised. Can you please provide more info:

what is the bookmark that has the korean word? is it in url, title, tags or description of bookmark? would you mind sharing it? what is the keyboard layout/standard you are using? what is the "Preferred languages" in System Preferences -> Language and Region? If you can, enable the debug option of workflow in Alfred and the use the search term. Then share the output in the debug window please?

This is interesting since, in my tests https://github.com/spamwax/rusty-pin/blob/26109a38817ae4ad76d7781affc9aae5f919ac78/src/pinboard/api.rs?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L351 we can handle non-english URLs!

— Reply to this email directly, view it on GitHub https://github.com/spamwax/alfred-pinboard-rs/issues/138#issuecomment-1004086766, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNF6ENJYFOZD4IAZ5FPFTTUUGPADANCNFSM5LET6GJQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.

<스크린샷 2022-01-04 오전 9.19.19.png><스크린샷 2022-01-04 오전 9.20.00.png><스크린샷 2022-01-04 오전 9.23.33.png><스크린샷 2022-01-04 오전 9.24.13.png>

spamwax commented 2 years ago

Thanks, I'll try to replicate but can you please follow my instructions and copy/paste the output of Alfred's debug window here when you enter 'ps 한글'

spamwax commented 2 years ago

I added a bookmark for https://blog.daum.net/bolee591/ with a keyword '한글' and it showed me the result! So I really need to see the debug output. There is a chance that one of your bookmarks is corrupted by an invalid non-UTF-8 character.

Screen Shot 2022-01-03 at 9 56 29 PM
spamwax commented 2 years ago

Does the Korean language have the concept of lower-case/upper-case? If it does, does it apply to any of the character in the bookmark that doesn't show up in Alferd after 'ps 한글'?

inchanS commented 2 years ago

"ps (english url title)" is available for url search. But "ps (Korean url title)" is not found. Only Korean Tags are searched. I want to search not only tags but also url titles in 'Hangul' language. Can you help me?

spamwax commented 2 years ago

@CreSeed Please open a different issue so I can try and debug your issue. However, I'll be fixing this issue soon and push a new update, so maybe after that update your problem will be resolved.