search

spamwax / alfred-pinboard-rs

Alfred Workflow for Pinboard (Rust)
Other
280 stars 13 forks source link

"hamid" username hardcoded in workflow #21

Closed luckman212 closed 6 years ago

luckman212 commented 6 years ago

First: great workflow! Thanks for making this.

Little bug: when using the alt modifier to Reveal the bookmark on the pinboard.in website, the constructed URL is incorrect since it hardcodes /u:hamid/?query=...

Better would be to grab the username somewhere when user sets the API key, or if that's not possible, then require the user to set it via a workflow environment variable e.g.

image

and then

image

spamwax commented 6 years ago

ugh... thanks for reporting. I'll fix it using one of the suggested methods and push an update soon.

matthauger commented 5 years ago

FWIW, I think I'm still seeing this issue in v0.14.5. User 'hamid' hard-coded into the 'Open URL' action.

(Thank you for this AMAZING workflow, which I use dozens of time each day.)

luckman212 commented 5 years ago

I thought the same thing, but after refreshing my authorization token and closing and reopening the window, the username did eventually update.

spamwax commented 5 years ago

@matthauger did what luckman212 provide resolve your issue?

matthauger commented 5 years ago

Resetting my Pinboard token does seem to have worked. Thanks, all!

On Sat, Jan 19, 2019 at 10:06 PM spamwax notifications@github.com wrote:

@matthauger https://github.com/matthauger did what luckman212 provide resolve your issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/spamwax/alfred-pinboard-rs/issues/21#issuecomment-455833625, or mute the thread https://github.com/notifications/unsubscribe-auth/AO8lQnPs9Ltvv6p_cwsh1UC8ShBN7S3kks5vE90zgaJpZM4YNarH .