spamwax / alfred-pinboard-rs

Alfred Workflow for Pinboard (Rust)
Other
280 stars 13 forks source link

Alfred exits after typing "p" while Firefox is focused #37

Closed kingdido999 closed 5 years ago

kingdido999 commented 5 years ago

Thanks for this awesome workflow!

My issue is that Alfred exists (with an alert sound) after I type "p" (basically every commands start with "p") in Alfred while Firefox is focused. If Firefox is not focused, typing "p" and related shortcuts works fine. I'm using a fresh install of this workflow with default configurations.

After some troubleshooting, I see the following known issue in README:

Firefox: While tag suggestions and "Check if page is bookmarked" options are enabled, posting bookmark from Firefox is broken. Deleting bookmarks using pind won't work when Firefox is your active browser. Reason: Firefox does not properly support interacting with it programatically.

So I set option "Check if page is bookmarked" to false, and now the issue goes away!

However, if I understand it correctly, this enabled option should only break the functionality of posting and deleting bookmark from Firefox. So it was not supposed to cause Alfred to error out and thus make this workflow unusable.

Please let me know if you need more information.

spamwax commented 5 years ago

All of "Check if page is bookmarked", delete page and suggest tags require to query fire-fox while you are typing the keywords and arguments. This is needed to get opened tab's info (title/url). As mentioned in README, this is not working and it's very unlikely to be fixed soon by Mozilla.

Posting a bookmark still works, because this workflow fetches title/url after you hit enter which means Alfred window is closed and that's why you don't see/hear any error.

Let's say those options are enabled, when you want to do a search ps, if you are not fast enough in typing, Alfred will interpret the first p as you wanting to post a bookmark and that's why you got those errors. You can test this by opening Alfred and pasting the ps into it (without typing).

To fix this, you can change "argument optional" of p keyword in workflow to "argument required"