search

spandex-project / spandex

A platform agnostic tracing library
MIT License
335 stars 53 forks source link

Update logger metadata when continue trace is called #111

Closed tjsousa closed 4 years ago

tjsousa commented 4 years ago

Since this entry point can be called when a distributed trace is received from another service, calling Logger.metadata in the same way it is called in start_trace/2 seems to cover that use-case (it should be idempotent, thus safe if the same trace_id is already there from another local process).

However, I believe this may also fix an issue as a new span is created when continuing a trace, which that should be updated in logs from this moment on.

Do you think this may be helpful?

dnlserrano commented 4 years ago

Yessss! 🤩

dnlserrano commented 4 years ago

Can we get a review here @zachdaniel or @GregMefford? 🙏

zachdaniel commented 4 years ago

Oof, sorry, this one got lost in the shuffle.

zachdaniel commented 4 years ago

Thank you for your contribution!

zachdaniel commented 4 years ago

Changes released as version 2.4.4