search

spandex-project / spandex

A platform agnostic tracing library
MIT License
335 stars 53 forks source link

feat!: allow headers to be passed into `Spandex.distributed_context/2` #113

Closed jfmyers9 closed 4 years ago

jfmyers9 commented 4 years ago

This change allows headers to be specified in Spandex.distributed_context/2 as an alternative to Plug.Conn. This is more compatible with the current signature of Spandex.inject_context/3 and allows Spandex to be used to extract trace information from connections that may not be relying on Plug e.g. GRPC.

Fixes #112

Haven't been using Elixir for too long, so let me know if there is anything funky going on that I should be doing differently.

PR for spandex_datadog will follow once this one gets sorted out.

zachdaniel commented 4 years ago

🚀Thank you for your contribution! 🚀

zachdaniel commented 4 years ago

@jfmyers9 if you could complete the corresponding work in spandex_datadog before long that would be great :D

zachdaniel commented 4 years ago

I've released spandex 3.0.0, but it will essentially be in an unusable state until the adapter is updated.

zachdaniel commented 4 years ago

Well, specifically 3.0.0 will be unusable (don't want anyone to get the wrong idea)

jfmyers9 commented 4 years ago

Planning on submitting the corresponding PR by tomorrow. Thanks for getting to this quickly.

On Wed, May 13, 2020, 8:47 PM Zach Daniel notifications@github.com wrote:

I've released spandex 3.0.0, but it will essentially be in an unusable state until the adapter is updated.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/spandex-project/spandex/pull/113#issuecomment-628320815, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH4X3QWLOQAQFTEJLZPE7TRRM5TXANCNFSM4M6DTNPQ .