Encode logger metadata as string.

spandex-project / spandex

A platform agnostic tracing library

MIT License

335 stars 53 forks source link

Encode logger metadata as string. #127

Closed aselder closed 3 years ago

aselder commented 3 years ago

This avoid a potential issue where JSON logs are parsed and numbers are treated as floats. This can lead to the trace and span ids losing precision when read from JSON.

If you look at the DataDog docs for other languages, you can see this. See: https://docs.datadoghq.com/tracing/connect_logs_and_traces/ruby/

Fixes #126

aselder commented 3 years ago

More or less a dup of #117