Open GregMefford opened 3 years ago
I came here looking for this exact issue. The Datadog API specs does not have a top-level version key (even though it is a part of unified service tagging): https://docs.datadoghq.com/tracing/guide/send_traces_to_agent_by_api/
Which means that some kind of transform layer would have to be done. It is that, or modify the interface to accept a top level attribute, but automatically add it into tag attributes. What probably should happen is span creation code pulls in the default version from DD_VERSION and inject it into every span, just like the officially supported SDK.
Since Datadog APM treats
env
,service
, andversion
as key attributes of a trace in its UI, we should allowversion
to also be set as a top-level attribute likeservice
andenv
are, rather than requiring it to be nested under thetags
attribute.https://github.com/spandex-project/spandex/blob/master/lib/span.ex#L48