Closed driv3r closed 7 years ago
Awesome work, I will look at it in just a few minutes :)
AddContext
plug that uses the configs, so if that isn't being used then those configs don't do anything.I'm creating issues for those three things.
@driv3r if there are no other changes you'd like to make to this PR, we can get it merged. Once the other issues I made from this have been resolved, we'll package up a release.
:+1: for merge
Once the other issues I made from this have been resolved, we'll package up a release.
I can probably start working on those right away ;)
reraise
statement intrace
decorator method, otherwise it swallows errorslog_entry
, otherwise other loggers failConfex
to v3.2 which allows you to set custom adaptersBesides that I found other things that I wanted to clarify first:
traced
decorator, nortrace
method which acceptsKeyword
of arguments, which leads us to next issueunknown
always, so it doesn't take under consideration settings defined in config, this should be probably fixed by applying Keyword args intrace
method?x-ddtrace-parent_trace_id
andx-ddtrace-parent_span_id
headers in order to support distributed tracing, and we could add some method to return this list of headers based on current span so You could just pass them further with api call, wdys?