Remove datadog adapter - Githubissues

spandex-project / spandex

A platform agnostic tracing library

MIT License

333 stars 53 forks source link

Remove datadog adapter #58

Closed zachdaniel closed 6 years ago

zachdaniel commented 6 years ago

The datadog adapter would now be found here: https://github.com/zachdaniel/spandex_datadog. Information on this update can be found in the readme below. I'm going to leave this PR up to give the community to respond. I'm not really sure how many people there are using this, but I know its a non-zero number of people I respect and don't want to mess with their workflows/time.

coveralls commented 6 years ago

Coverage decreased (-5.9%) to 70.647% when pulling 5691c5755443592d6d9fffa5857040b9c61207b2 on remove-datadog-adapter into 2612a5693804715bc6a290401937223a144c25fa on master.

GregMefford commented 6 years ago

Resolves #39

zachdaniel commented 6 years ago

Good question about the versions. I worry a bit about having bidirectional dependencies though, because it seemed logical to instead have adapters say which version of spandex they work for, as opposed to having core declare which adapter versions work with it.

sourcelevel-bot[bot] commented 6 years ago

Ebert has finished reviewing this Pull Request and has found:

5 possible new issues (including those that may have been commented here).
17 fixed issues! 🎉

But beware that this branch is 1 commit behind the zachdaniel:master branch, and a review of an up to date branch would produce more accurate results.

You can see more details about this review at https://ebertapp.io/github/zachdaniel/spandex/pulls/58.