Closed sekiyama58 closed 6 years ago
Hello, @sekiyama58! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.
Thanks for your contribution! Additionally, thanks for including a test to validate your change. Much appreciated.
Currently, even when
Tracer.configure(disabled?: true)
is called, the spandex is not disabled.There is another issue that calls of
trace_start
andspan_start
after dynamic configuration of tracer usingTracer.configure(service: :app, adapter: ..., disabled?: true)
will cause exception like:This is because the option is not
Application.put_env
whendisabled?: true
.This patch fixes the issue.