search

spandex-project / spandex

A platform agnostic tracing library
MIT License
333 stars 53 forks source link

Allow to pass more span metadata to `span` with block #73

Closed sekiyama58 closed 6 years ago

sekiyama58 commented 6 years ago

Currently metadata is only allowed in update_span arguments. For simplicity, it would be nice if we can pass metadata arguments to Tracer.span with block, like

    Tracer.span("span_me_also", resource: "aaa", sql_query: [query: "..."]) do
      ...
    end
zachdaniel commented 6 years ago

AFAIK this is how it works. You should be able to pass in any data on creation that you can on update_span.

zachdaniel commented 6 years ago

Have you confirmed that the metadata set that way is not honored?

sekiyama58 commented 6 years ago

Thanks for response. I have tried again with v2.1.0 and the issue was not confirmed. It seems I have been confused by dynamic configuration issue that is fixed by 2.1.0 release. So I'm closing this issue now.

Thanks!