Add inject_context and current_context

spandex-project / spandex

A platform agnostic tracing library

MIT License

333 stars 53 forks source link

Add inject_context and current_context #78

Closed GregMefford closed 6 years ago

GregMefford commented 6 years ago

Adds APIs for current_context (to allow people to get access to a SpanContext based on the current span context) and inject_context to simplify adding distributed tracing headers to HTTP calls.

This somewhat-unfortunately also required an update to the Adapter behaviour, so I've also got a PR to SpandexDatadog queued up (https://github.com/spandex-project/spandex_datadog/pull/6).

sourcelevel-bot[bot] commented 6 years ago

Ebert has finished reviewing this Pull Request and has found:

4 possible new issues (including those that may have been commented here).
1 fixed issue! 🎉

You can see more details about this review at https://ebertapp.io/github/spandex-project/spandex/pulls/78.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 348

8 of 9 (88.89%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 82.329%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
test/support/adapter.ex	4	5	80.0%
<!--	Total:	8	9	88.89%	-->

Totals
Change from base Build 340:	0.2%
Covered Lines:	205
Relevant Lines:	249

Ok, I think this PR is ready to merge. If you think these last commits are good, I can hit the button and then work on a release-prep PR for 2.3.0 so that I can bump the version requirement in spandex_datadog.

spandex-project / spandex

Add inject_context and current_context #78

Pull Request Test Coverage Report for Build 348

💛 - Coveralls