!fix: Only inherit sensible attribute from parents

spandex-project / spandex

A platform agnostic tracing library

MIT License

335 stars 53 forks source link

!fix: Only inherit sensible attribute from parents #86

Closed zachdaniel closed 4 years ago

zachdaniel commented 5 years ago

If you are using the private key for tags, you will need to switch to using tags, or the appropriate top level tag attribute like sql_query or http.

This is also 1 considered a breaking change because it is likely/possible that implementations were relying on this behavior. If you aren't leveraging tags, or if your spans aren't very deep in general than you most likely don't need to deal with this.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 050910da-00a9-4346-ad96-afc3cd3c1d5e

7 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.2%) to 84.524%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/span.ex	7	8	87.5%
<!--	Total:	7	8	87.5%	-->

Totals
Change from base Build 7182e4ff-b3ad-45af-bc71-390b20d7b463:	2.2%
Covered Lines:	213
Relevant Lines:	252

💛 - Coveralls

GregMefford commented 5 years ago

Maybe we should think about how to mark this as deprecated so that we could get it merged, and then remove it when we decide we're ready for 3.0 (assuming that ever happens).

zachdaniel commented 5 years ago

@GregMefford I don't really think there is a good way to mark the existing behavior as deprecated. I think we'd just need a major version change to include it. No one will accidentally upgrade, and we can make it really big on the readme. Beyond that, there isn't much we can do.

zachdaniel commented 4 years ago

This is old/stale, and I'm not really making any behavioral changes to Spandex except in reaction to issues.