add `enabled` config option and deprecate `disabled?` option

spandex-project / spandex

A platform agnostic tracing library

MIT License

333 stars 53 forks source link

add `enabled` config option and deprecate `disabled?` option #94

Open GregMefford opened 5 years ago

GregMefford commented 5 years ago

I think it's kind of confusing to have negative configuration options like disabled?: true rather than enabled: false. I also think it looks weird to have configuration options with question marks at the end, but I might be the one who's wrong on that one. It bothers me less when it's a function name.

I think we could make this change without breaking anything, so it doesn't need to wait for the 3.0.0 milestone.

zachdaniel commented 4 years ago

This should be a relatively easy change to add, we'll just have to respect both flags for a period of time.