search

spandex-project / spandex_datadog

A datadog adapter for the `spandex` library.
MIT License
59 stars 42 forks source link

feat: add support for app analytics #23

Closed baquiax closed 4 years ago

baquiax commented 4 years ago

One of the most useful features of DataDog is the App Analytcs https://docs.datadoghq.com/tracing/app_analytics. It allows you track the 100% of your traces to have a full visilibity about what's going on.

We add this new feature to support it. You only need to add in the tags the key-value: :analytics_event: true.

baquiax commented 4 years ago

@zachdaniel @GregMefford I hope this PR accomplish the standard on the package.

zachdaniel commented 4 years ago

@baquiax this looks good to me, have you had a chance to confirm that it works as expected in datadog?

baquiax commented 4 years ago

Thanks for reply @zachdaniel

Yes, I did. Here I attach a screen of my last tests.

image

zachdaniel commented 4 years ago

Thank you for your contribution!

baquiax commented 4 years ago

You are welcome @zachdaniel , thanks to you for build this project. I'll create another PR adding examples of how to use this dep.

GregMefford commented 4 years ago

Thank you so much for taking the time to fix and test this! I’ve been meaning to look into this for a long time and just haven’t gotten the time yet! 🚀❤️