Update min version of telemetry

spandex-project / spandex_datadog

A datadog adapter for the `spandex` library.

MIT License

59 stars 42 forks source link

Update min version of telemetry #43

Closed ayrat555 closed 3 years ago

ayrat555 commented 3 years ago

:telemetry.span was added in the version 0.4.2 of the telemetry

so spandex_datadog fails with the following message if earlier versions are used

** (UndefinedFunctionError) function :telemetry.span/3 is undefined or private

maybe it's worth updating to the latest version of telemetry (1.0) but I think it will require more changes

ayrat555 commented 3 years ago

@GregMefford @zachdaniel hey

Can you please check out open prs (including this one) :]

GregMefford commented 3 years ago

Ah, thanks for taking the time to open a PR! I will take a look at this and make sure that we can also support 1.0 (I think we probably can) and then I'll make it so that Spandex can work with ~> 0.4.2 or ~> 1.0, so that we don't prevent people from upgrading to 1.0. 🚀