search

spandex-project / spandex_datadog

A datadog adapter for the `spandex` library.
MIT License
59 stars 42 forks source link

fix: convert tags boolean values different from other atoms #61

Closed DReigada closed 1 year ago

DReigada commented 1 year ago

The Datadog agent trace API only supports strings for metadata keys and values.

We encountered an error when we tried to send tags with booleans as values.

This should convert booleans like we do for other terms.

DReigada commented 1 year ago

For some reason GitHub decided to close the PR. Because I mentioned it in another PR (in a private project) 🤦

GregMefford commented 1 year ago

Thank you for submitting this! It's such a small but helpful change. It's something that has caught my colleagues and me several times in the past, but I never got around to fixing it. ❤️