spandex-project / spandex_phoenix

Phoenix Instrumentation tracer
MIT License
82 stars 29 forks source link

add a usable instrumenter for better configuration #21

Closed zachdaniel closed 4 years ago

zachdaniel commented 5 years ago

With this you can define your own instrumenter and customize either the otp_app or the tracer when doing so:

defmodule MyApp.SpandexInstrumenter do
  use Spandex.Instrumenter, otp_app: :my_app

  # OR

  use Spandex.Instrumenter, tracer: MyApp.Tracer
end

Resolves #20

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 938fc0f0-0811-410a-b3e1-8f08697fcb5a


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/spandex_phoenix/instrumenter.ex 0 6 0.0%
<!-- Total: 0 6 0.0% -->
Files with Coverage Reduction New Missed Lines %
lib/spandex_phoenix/instrumenter.ex 4 0.0%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 6e9817a9-354c-4575-97c1-00cd059036db: -1.7%
Covered Lines: 61
Relevant Lines: 86

💛 - Coveralls
zachdaniel commented 5 years ago

Sounds good

sourcelevel-bot[bot] commented 5 years ago

SourceLevel has finished reviewing this Pull Request and has found:

You can see more details about this review at https://app.sourcelevel.io/github/spandex-project/spandex_phoenix/pulls/21.

bdubaut commented 5 years ago

This change should probably also be reflected in the library's README