Support Phoenix Telemetry events

spandex-project / spandex_phoenix

Phoenix Instrumentation tracer

MIT License

82 stars 29 forks source link

Support Phoenix Telemetry events #23

Closed GregMefford closed 4 years ago

GregMefford commented 4 years ago

Phoenix will soon deprecate the instrumenters API that we currently use to collect instrumentation, in favor of Telemetry events: https://hexdocs.pm/phoenix/Phoenix.Endpoint.html#module-instrumentation

We should probably add some simple adapter functions to SpandexPhoenix.Instrumenter so that it will be an easy conversion to delegate to that module for either instrumenters or Telemetry events.

egze commented 4 years ago

Hi. Phoenix 1.5 is here.

Now it produces this warning: 12:22:30.755 [warn] :instrumenters configuration for Web.Endpoint is deprecated and has no effect

Is there any quick fix for this?

novaugust commented 4 years ago

@GregMefford I have a day or two of OSS time built up, I'll see if I can spike something up for this