search

spandex-project / spandex_phoenix

Phoenix Instrumentation tracer
MIT License
82 stars 29 forks source link

Update docs to help with installation #54

Closed RicardoTrindade closed 2 years ago

RicardoTrindade commented 2 years ago

Tiny PR updating the installation guide that hopes to help others in a similar situation.

When configuring spandex_phoenix and spandex_datadog it took me a while until the traces started to show in Datadog. Was only after I added service name in config.exs that tracing started to work properly.

sourcelevel-bot[bot] commented 2 years ago

Hello, @RicardoTrindade! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

GregMefford commented 2 years ago

Hey, thank you for taking the time to open this PR! Actually this configuration isn't necessary because you only need to configure spandex_phoenix so that it knows which Tracer module to use. Any other configuration would just be ignored.