spanezz / nodm

Automatic display manager
GNU General Public License v2.0
141 stars 21 forks source link

Handle quit signals better #13

Open dgw opened 6 years ago

dgw commented 6 years ago

Fixes #5, nodm will now correctly shut down instead of restarting when systemd tries to kill it

This is a repackage of #10, which seems unlikely to ever be rebased by its author, whose GitHub activity shows that PR was their first and last (public) GitHub action.

I don't care if this is merged as-is, or used to overwrite @slashblog's branch and then merged via #10. It just seemed useful to take the rebase/squash step out of the equation and maybe get this fix landed. :smile_cat:

rcorre commented 6 years ago

@sunweaver Any chance this will be merged to mainstream? I've been using it for a few days on multiple archlinux machines and I can now shutdown successfully.

sunweaver commented 6 years ago

Hi,

On Mi 12 Sep 2018 14:53:05 CEST, Ryan Roden-Corrent wrote:

@sunweaver Any chance this will be merged to mainstream? I've been
using it for a few days on multiple archlinux machines and I can now
shutdown successfully.

Will do... nodm in Debian must receive another upgrade round, too. On
my list...

Greets, Mike --

DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

tadly commented 6 years ago

Just to make sure, will you bump the version as well after merging this?

cesetxeberria commented 5 years ago

Hi Is this going to be merged to mainstream? Just tried a fresh install of debian buster, which is in freeze process now, and the problem isn't fixed there.

TheNeikos commented 5 years ago

@sunweaver A small bump :grinning: