spanezz / staticsite

Static site generator
GNU General Public License v3.0
45 stars 7 forks source link

Cannot install with pip #48

Closed TobiX closed 4 years ago

TobiX commented 4 years ago

When trying to install with

pip install -e .

the install process stops because setup.py references the old PIL instead of the modern fork Pillow.

After fixing this, running ssite serve from a clean virtualenv also fails, because the required pyinotify dependency is undeclared in setup.py...

spanezz commented 4 years ago

I personally don't use pip and virtualenv and I probably am not very good at keeping this part well polished. I do very much welcome feedback like yours, which helps me a lot in that.

I pushed the fixes for the bits you noted. Does it work now?

TobiX commented 4 years ago

Looks fine to me now. Shortened transcript:

> mktmpenv
[...]
This is a temporary environment. It will be deleted when you run 'deactivate'.
(tmp-84bc03adaa22011) ~/.virtualenvs/tmp-84bc03adaa22011/ > git clone https://github.com/spanezz/staticsite.git
Cloning into 'staticsite'...
[...]
(tmp-84bc03adaa22011) ~/.virtualenvs/tmp-84bc03adaa22011/ > cd staticsite
(tmp-84bc03adaa22011) ~/.virtualenvs/tmp-84bc03adaa22011/staticsite/ > pip install -e .[serve]
Obtaining file://~/.virtualenvs/tmp-84bc03adaa22011/staticsite
Collecting markdown
[...]
Installing collected packages: markdown, docutils, toml, pyyaml, ruamel.yaml.clib, ruamel.yaml, MarkupSafe, jinja2, Pillow, six, python-dateutil, text-unidecode, python-slugify, pytz, tornado, pyinotify, staticsite
  Running setup.py develop for staticsite
Successfully installed MarkupSafe-1.1.1 Pillow-7.0.0 docutils-0.16 jinja2-2.11.1 markdown-3.1.1 pyinotify-0.9.6 python-dateutil-2.8.1 python-slugify-4.0.0 pytz-2019.3 pyyaml-5.3 ruamel.yaml-0.16.7 ruamel.yaml.clib-0.2.0 six-1.14.0 staticsite text-unidecode-1.3 toml-0.10.0 tornado-6.0.3
(tmp-84bc03adaa22011) ~/.virtualenvs/tmp-84bc03adaa22011/staticsite/ > ln -s $PWD/themes ../bin
(tmp-84bc03adaa22011) ~/.virtualenvs/tmp-84bc03adaa22011/staticsite/ > ssite serve
http://127.0.0.1:8000
2020-02-05 14:46:59,700 WARNING 404 GET /robots.txt (127.0.0.1) 0.68ms
spanezz commented 4 years ago

Perfect, thanks! I'll close the issue