search

spaniakos / Cryptosuite

Cryptographic suite for Arduino & RPi (SHA, HMAC-SHA)
http://spaniakos.github.io/Cryptosuite/
GNU Affero General Public License v3.0
23 stars 11 forks source link

Added support for TI Launchpad #1

Open TransientResponse opened 9 years ago

TransientResponse commented 9 years ago

These additions add suport for TI Tiva C-Series Launchpad boards, in particular the EK-TM4C1294 Connected Launchpad. Support for others can be added very easily by simply adding another defined(...) clause in the header's #if statements.

Also, the result() functions now take one argument: a user-supplied array of byte (that is, unsigned char or uint8_t) allocated to 32 bytes. Before, these functions returned a raw pointer to the SHA function's internal state, which could allow the user to accidentally (or intentionally) corrupt said state. Now the library copies bytes from the SHA's state to the user-supplied array.

spaniakos commented 9 years ago

Thanks for the support . I won't be able to check it until monday. Will check and merge it then. On Dec 20, 2014 3:24 PM, "TransientResponse" notifications@github.com wrote:

These additions add suport for TI Tiva C-Series Launchpad boards, in particular the EK-TM4C1294 Connected Launchpad. Support for others can be added very easily by simply adding another defined(...) clause in the header's #if statements.

Also, the result() functions now take one argument: a user-supplied array of byte (that is, unsigned char or uint8_t) allocated to 32 bytes. Before, these functions returned a raw pointer to the SHA function's internal state, which could allow the user to accidentally (or intentionally) corrupt said state. Now the library copies bytes from the

SHA's state to the user-supplied array.

You can merge this Pull Request by running

git pull https://github.com/TransientResponse/Cryptosuite master

Or view, comment on, or merge it at:

https://github.com/spaniakos/Cryptosuite/pull/1 Commit Summary

  • Adapted to work on TI Launchpad TM4C1294
  • Now (should) work with Arduino and RPi also
  • Fixed compatibility with Arduino, RPi, Galileo
  • Fixed memory location for PROGMEM
  • Ported changes to SHA1

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/spaniakos/Cryptosuite/pull/1.

TransientResponse commented 9 years ago

OK.

Sent from my Windows Phone

From: Georgios Spanosmailto:notifications@github.com Sent: ‎12/‎20/‎2014 9:46 AM To: spaniakos/Cryptosuitemailto:Cryptosuite@noreply.github.com Cc: TransientResponsemailto:TransientResponse@outlook.com Subject: Re: [Cryptosuite] Added support for TI Launchpad (#1)

Thanks for the support . I won't be able to check it until monday. Will check and merge it then. On Dec 20, 2014 3:24 PM, "TransientResponse" notifications@github.com wrote:

These additions add suport for TI Tiva C-Series Launchpad boards, in particular the EK-TM4C1294 Connected Launchpad. Support for others can be added very easily by simply adding another defined(...) clause in the header's #if statements.

Also, the result() functions now take one argument: a user-supplied array of byte (that is, unsigned char or uint8_t) allocated to 32 bytes. Before, these functions returned a raw pointer to the SHA function's internal state, which could allow the user to accidentally (or intentionally) corrupt said state. Now the library copies bytes from the

SHA's state to the user-supplied array.

You can merge this Pull Request by running

git pull https://github.com/TransientResponse/Cryptosuite master

Or view, comment on, or merge it at:

https://github.com/spaniakos/Cryptosuite/pull/1 Commit Summary

  • Adapted to work on TI Launchpad TM4C1294
  • Now (should) work with Arduino and RPi also
  • Fixed compatibility with Arduino, RPi, Galileo
  • Fixed memory location for PROGMEM
  • Ported changes to SHA1

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/spaniakos/Cryptosuite/pull/1.

Reply to this email directly or view it on GitHub: https://github.com/spaniakos/Cryptosuite/pull/1#issuecomment-67737781

spaniakos commented 9 years ago

hello.

i have cchecked your code and it seems good. but i cannot accept the pull request as i have some changes in my file structure, and some code separation and/or cleanup. i can implement the changes but hand if you want, or i can wait if you like to re-fork or commitmy changes and re-add the missing code from your. If this is too much to ask, u can always just implement the canges by hand and add you to the Readme file as a contritbutor.

Thanks spaniakos

TransientResponse commented 9 years ago

Commit your changes and I'll re-add mine afterwards. It'll also give me time to implement a few other changes that I had in mind.

Sent from my Windows Phone

From: Georgios Spanosmailto:notifications@github.com Sent: ‎12/‎23/‎2014 8:46 AM To: spaniakos/Cryptosuitemailto:Cryptosuite@noreply.github.com Cc: TransientResponsemailto:TransientResponse@outlook.com Subject: Re: [Cryptosuite] Added support for TI Launchpad (#1)

hello.

i have cchecked your code and it seems good. but i cannot accept the pull request as i have some changes in my file structure, and some code separation and/or cleanup. i can implement the changes but hand if you want, or i can wait if you like to re-fork or commitmy changes and re-add the missing code from your. If this is too much to ask, u can always just implement the canges by hand and add you to the Readme file as a contritbutor.

Thanks spaniakos

Reply to this email directly or view it on GitHub: https://github.com/spaniakos/Cryptosuite/pull/1#issuecomment-67952038

spaniakos commented 9 years ago

my changes are now commited, had some file separation as you can see. i am revising all my libraries today as i moved my equipment from my lab to a vacation place, thow i still have to implement code :D. by the end of tomorrow i would have implemented any change i might do from the revision.

thanks.