spantaleev / matrix-docker-ansible-deploy

🐳 Matrix (An open network for secure, decentralized communication) server setup using Ansible and Docker
GNU Affero General Public License v3.0
4.88k stars 1.04k forks source link

self-check in nginx-prox assumes well-known file is used #1638

Open openbrian opened 2 years ago

openbrian commented 2 years ago

I'm very new to this project and ansible in general. I just fired up the default configuration for the first time. I do run my own name server, so I chose to use SRV records for server delegation.

I set matrix_well_known_matrix_server_enabled: false in my vars.yml.

When I run the self-check. I get an error about

TASK [matrix-nginx-proxy: Check .well-known on the identity hostname]

Shouldn't this have a when: matrix_well_known_matrix_server_enabled condition?

Let me know if you want a PR.

spantaleev commented 2 years ago

Looks like you're correct! A PR is welcome