Closed aine-etke closed 2 years ago
@dsonck92 could you check it, please?
It seems like the pipeline used a different node while building than the dockerfile from used. I did some changes to that to fix this, so I'm rerunning the pipeline so v0.1.1 will be retagged with a working version.
It might be safer to retag as v0.1.1-2
or v0.1.2
or something, so that people who already pulled via the playbook will get a new one when we bump our version. We (and Docker in general) don't force-pull tags, as we don't expect them to have changed (unless it's :latest
).
In general I do agree with that stance, except that in this case the image was not functional at all due to misconfigured external ci config. There's actually no change in the code at all as all bridges build from the same instructions. But I can create a new tag, which would be exactly the same as v0.1.1.
Actually, scratch that, the pipeline failed anyways, so I'll be trying to build v0.1.2
Version v0.1.2
is out now. Again, I don't use it myself, but I think it should work considering the branch version mentioned earlier was tested by someone, and this only builds everything on node 17, and ensures all stages do that.
I've upgraded us to v0.1.2. Hopefully it works!
Alright! Well, please let me know, for me it's also better if I can safely say v0.1.2 works (which should have been v0.1.0)
It works, thank you!
Describe the bug mx-puppet-slack pre-built image fails to start (again) even after the #1825
To Reproduce
Just run the
-t setup-all
with #1825 changesExpected behavior It works
Logs