search

spantaleev / matrix-docker-ansible-deploy

🐳 Matrix (An open network for secure, decentralized communication) server setup using Ansible and Docker
GNU Affero General Public License v3.0
4.72k stars 1.02k forks source link

just roles ntfy broken #3004

Closed darksnakezero closed 9 months ago

darksnakezero commented 9 months ago

Describe the bug "just roles" fails to install ntfy. `just roles Starting galaxy role install process

The suggested workaround flag does not work either: `just --ignore-errors roles error: Found argument '--ignore-errors' which wasn't expected, or isn't valid in this context

USAGE: just [FLAGS] [OPTIONS] [--] [ARGUMENTS]...

For more information try --help`

To Reproduce My vars.yml file looks like this:

# The bare domain name which represents your Matrix identity.
# Matrix user ids for your server will be of the form (`@user:<matrix-domain>`).
#
# Note: this playbook does not touch the server referenced here.
# Installation happens on another server ("matrix.<matrix-domain>").
#
# If you've deployed using the wrong domain, you'll have to run the Uninstalling step,
# because you can't change the Domain after deployment.
#
# Example value: example.com
matrix_domain: [DOMAIN].com

# This is something which is provided to Let's Encrypt when retrieving SSL certificates for domains.
#
# In case SSL renewal fails at some point, you'll also get an email notification there.
#
# If you decide to use another method for managing SSL certifites (different than the default Let's Encrypt),
# you won't be required to define this variable (see `docs/configuring-playbook-ssl-certificates.md`).
#
# Example value: someone@example.com
matrix_ssl_lets_encrypt_support_email: '[EMAIL]'

# A shared secret (between Coturn and Synapse) used for authentication.
# You can put any string here, but generating a strong one is preferred (e.g. `pwgen -s 64 1`).
matrix_coturn_turn_static_auth_secret: '[LONG STRING OF CHARACTERS AND NUMERS]'

# A secret used to protect access keys issued by the server.
# You can put any string here, but generating a strong one is preferred (e.g. `pwgen -s 64 1`).
matrix_synapse_macaroon_secret_key: '[LONG STRING OF CHARACTERS AND NUMERS]'

# All secrets keys are now derived from `matrix_homeserver_generic_secret_key`, not from `matrix_synapse_macaroon_secret_key`.
# To keep them all the same, define `matrix_homeserver_generic_secret_key` in terms of `matrix_synapse_macaroon_secret_key`.
# Using a new secret value for this configuration key is also possible and should not cause any problems.
#
# Fun fact: new installations (based on the new `examples/vars.yml` file) do this in reverse.
# That is, the Synapse macaroon secret is derived from `matrix_homeserver_generic_secret_key`.
matrix_homeserver_generic_secret_key: "{{ matrix_synapse_macaroon_secret_key }}"

# A Postgres password to use for the superuser Postgres user (called `matrix` by default).
#
# The playbook creates additional Postgres users and databases (one for each enabled service)
# using this superuser account.
devture_postgres_connection_password: '[LONG STRING OF CHARACTERS AND NUMERS]'

matrix_playbook_reverse_proxy_type: playbook-managed-nginx
matrix_nginx_proxy_enabled: true

#Base domain is provided by nginx
matrix_nginx_proxy_base_domain_serving_enabled: true
#Get valid SSL Cert for nextcloud
matrix_ssl_additional_domains_to_obtain_certificates_for:
- [DOMAIN]

#readable version in separate file
#Setup nginx to relay traffic for nextcloud
matrix_nginx_proxy_proxy_http_additional_server_configuration_blocks:
- "server {\r\n        listen 8080;\r\n        listen [::]:8080;\r\n\r\n        server_name [OTHERSERVER];\r\n        server_tokens off;\r\n\r\n                location /.well-known/acme-challenge {\>

#enable nginx status webpanel
matrix_nginx_proxy_proxy_matrix_nginx_status_enabled: true

#allow access to status webpanel for pc .30
matrix_nginx_proxy_proxy_matrix_nginx_status_allowed_addresses:
- [LOCAL IP ADRESS]

#enable synapse admin interface
matrix_synapse_admin_enabled: true

#activate shared secret auth
#enables automatic pupeteering
matrix_synapse_ext_password_provider_shared_secret_auth_enabled: true
matrix_synapse_ext_password_provider_shared_secret_auth_shared_secret: '[LONG STRING OF CHARACTERS AND NUMERS]'

#enable mautrix-telegram
matrix_mautrix_telegram_enabled: true
matrix_mautrix_telegram_api_id: [API ID]
matrix_mautrix_telegram_api_hash: [HASH]

#enable mautrix-whatsapp
matrix_mautrix_whatsapp_enabled: true

#enable mx-puppet-discord
matrix_mx_puppet_discord_enabled: true

#enable mautrix-discord
matrix_mautrix_discord_enabled: true

#enable matrix reminder bot
matrix_bot_matrix_reminder_bot_enabled: true

# Adjust this to whatever password you chose when registering the bot user
matrix_bot_matrix_reminder_bot_matrix_user_password: [LONG STRING OF CHARACTERS AND NUMERS]

# Adjust this to your timezone
matrix_bot_matrix_reminder_bot_reminders_timezone: Europe/London

#compress the state table periodically -> Less Memory usage
matrix_synapse_auto_compressor_enabled: true

1) do a git pull 2) adjust vars.yaml 3) do a "just roles" 4) observe the error and be unable to update/restart anything

Expected behavior No error in just roles.

Matrix Server:

Ansible: If your problem appears to be with Ansible, tell us:

Additional context Add any other context about the problem here. If this should be reported somewhere else, please kindly tell me.

If there is any way to exclude the ntfy role, please also tell me, as I dont want to use the ntfy service.

darksnakezero commented 9 months ago

Additional information: This seems to be due to the change in line 58 of requirements.yml: https://github.com/spantaleev/matrix-docker-ansible-deploy/commit/ef3f3741c9e355282f975d5e2ccb5ae81c26d1fd

Reverting this change fixes the problem. This is probably caused by the missing tag of Aines newest commit. The reference by version number might need the tag.

Going to report this with the Ntfy repo now

spantaleev commented 9 months ago

It should be fixed now

darksnakezero commented 9 months ago

It is. The missing tag seems to have been the problem.

Keep up the good work!