sparcians / mavis

RISC-V Decoder
Apache License 2.0
1 stars 5 forks source link

makeInstDirectory does not support vector masks or any other special fields #15

Open kathlenemagnus opened 1 month ago

kathlenemagnus commented 1 month ago

I am using makeInstDirectly() to create vector instructions like this:

// initialize mnemonic, srcs and dests
mavis::ExtractorDirectOpInfoList ex_info(mnemonic, srcs, dests);                    
InstPtr inst = mavis_facade_->makeInstDirectly(ex_info, clk);

But there is no mechanism for adding special fields to the ExtractorDirectOpInfoList. I would like to be able to provide a map of special fields and their values like this:

std::map<mavis::OpcodeInfo::SpecialField, uint64_t> special_fields = {mavis::OpcodeInfo::SpecialField::VM : "0"};
h0lyalg0rithm commented 1 month ago

@kathlenemagnus Is this the issue you mentioned in the weekly meeting?

Shubhf commented 3 weeks ago

@kathlenemagnus Can I take up this issue?

kathlenemagnus commented 3 weeks ago

@Shubhf yes please do! Thanks.

kathlenemagnus commented 3 weeks ago

@kathlenemagnus Is this the issue you mentioned in the weekly meeting?

I mentioned this one: https://github.com/sparcians/mavis/issues/14

But you're welcome to work on any of the open issues.

Shubhf commented 3 weeks ago

Hey @kathlenemagnus I have tried to make some changes .. Actually I am facing issue with understanding of main.cpp file .. I am looking for feedback