Two tiny corrections found by mypy 1.13

sparckles / Robyn

Robyn is a Super Fast Async Python Web Framework with a Rust runtime.

https://robyn.tech/

BSD 2-Clause "Simplified" License

4.45k stars 229 forks source link

Two tiny corrections found by mypy 1.13 #1032

Closed dave42w closed 5 days ago

dave42w commented 6 days ago

Description

This PR fixes two problems found by the mypy typechecker.

processpool.py reuse of route_trype local var for two different actual types ws.py was missing dict type self.methods: dict = {}

PR Checklist

Please ensure that:

[X ] The PR contains a descriptive title
[ X] The PR contains a descriptive summary of the changes
[ X] You build and test your changes before submitting a PR.
[ X] You have added relevant documentation
[ X] You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

[ X] Ensure that you have run the pre-commit hooks on your PR.

vercel[bot] commented 6 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
robyn	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 16, 2024 1:20am

codspeed-hq[bot] commented 6 days ago

CodSpeed Performance Report

Merging #1032 will not alter performance

_{Comparing dave42w:my-py2 (b347d17) with main (5589ddf)}

Summary

✅ 146 untouched benchmarks

dave42w commented 6 days ago

Hi @sansyrox

Sorry about this. I don't see how this build timeout could be caused by my code.

sansyrox commented 6 days ago

Hey @dave42w 👋

Don't worry about it :D

dave42w commented 5 days ago

Hey @dave42w 👋

Don't worry about it :D

Is there anything I can/should do to trigger a re-check so this can be merged?

BTW did you see this warning from CI:

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

I guess it might be part of the cause of the failure

sansyrox commented 5 days ago

@dave42w ,

That is coming from on of the dependencies. But we should update that for sure !