Closed dave42w closed 3 days ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
robyn | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 20, 2024 10:46pm |
Comparing dave42w:mypy2
(be555e7) with main
(3f2e79a)
✅ 146
untouched benchmarks
Description
This PR fixes most of the mypy warnings in router.py
Summary
This PR does not fix https://github.com/sparckles/Robyn/issues/1035 where add_route is inconsistent between the BaseRouter(ABC) and it's subclasses.
The biggest changes were in Router. _format_response
if "x" in headers
replaced withif headers.contains("x")
Beyond that a few places with a missing dict type: for injected_dependencies x 2 and self.reoutes x 1
PR Checklist
Please ensure that:
Pre-Commit Instructions: