search

sparckles / Robyn

Robyn is a Super Fast Async Python Web Framework with a Rust runtime.
https://robyn.tech/
BSD 2-Clause "Simplified" License
4.19k stars 214 forks source link

docs: New docs fixes #651

Closed elliotwaite closed 10 months ago

elliotwaite commented 10 months ago

Some small fixes for the new docs. Let me know if any of them are incorrect.

Also, on mobile I am unable to click the last link in the left nav panel for "Upcoming Features". This is because the bottom "X" button is in a div that spans the full width of that nav area and covers that bottom link:

image

It seems like a good fix would be to make it so the div containing the "X" button was only as wide as the "X" button so that users could still click links in that bottom area to the right of that button. It might also be good to add some extra bottom padding to that nav area so that when users scrolled to the bottom of that nav list, the last item would be shown above that "X" button.

netlify[bot] commented 10 months ago

Deploy request for robyn pending review.

Visit the deploys page to approve it

Name Link
Latest commit 1a9caff83f96e2c5fd7469e6acd9cd0209133557
vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 1:19pm
sansyrox commented 10 months ago

Thanks for the docs update @elliotwaite 😄 They LGTM 😄

It seems like a good fix would be to make it so the div containing the "X" button was only as wide as the "X" button so that users could still click links in that bottom area to the right of that button. It might also be good to add some extra bottom padding to that nav area so that when users scrolled to the bottom of that nav list, the last item would be shown above that "X" button.

Yes, these are good solutions! I will try implementing them tomorrow :D

elliotwaite commented 10 months ago

Sounds good.