Closed JosephMcArthur closed 4 years ago
Print CSS doesn’t work the same way across browsers. Very likely that we won’t be able to make it look nice on Safari.
Tested with latest versions of browsers on devices:
Tested with Chrome’s inspector (this mostly tests for viewport size):
I've hidden about us button for now, which is why it isn't coming up. That's intended.
On Thu, Jun 18, 2020, 1:48 PM Sophy notifications@github.com wrote:
Tested with latest versions of browsers on devices:
- MacOS
- Chrome
- Firefox
- Safari
- iOS
- Chrome
- Safari
- Android
- Chrome
Tested with Chrome’s inspector (this mostly tests for viewport size):
- Moto G4 (really small viewport...)
- Pixel 2
- iPhone X
- iPad
- iPad Pro
TODO
- https://infrastructure.sparcopen.org/about: portraits overflow
https://infrastructure.sparcopen.org/roadmap-for-action/what-do-we-mean-by-data-and-data-infrastructure: anchor link is displayed by default; should only appear on hover, focus, & active
https://infrastructure.sparcopen.org/roadmap-for-action/what-do-we-mean-by-data-and-data-infrastructure: previous/next pagination needs some margin in between
https://infrastructure.sparcopen.org/roadmap-for-action/what-do-we-mean-by-data-and-data-infrastructure: should not display print post button on mobile or tablet
https://infrastructure.sparcopen.org//roadmap-for-action/three-categories-of-action: related box shouldn’t fall below the footer
- Print doesn’t look the same on MacOS Firefox & Safari
- Print on MacOS Safari:
has its own cover page; the rest of the text is in a narrow column which doesn’t look too awful - Print on MacO Firefox: a lot of white space around
; blank page - https://infrastructure.sparcopen.org//landscape-analysis/wiley: iPad portrait and landscape + iPad Pro portrait: second and third col (Related) are too narrow
- https://infrastructure.sparcopen.org/landscape-analysis/wiley: iPhone + iPad: About Us button doesn’t appear
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sparcopen/infrastructure/issues/20#issuecomment-645995492, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFZMZ6KREWY5BKK5SLSL6LRXIELFANCNFSM4NOT3ITQ .
Ah just noticed it now. Will still fix the small issue related to the About page on mobile.
Hoping Sophy can do this.