sparcs-kaist / zabo-front-reactjs

Image and Poster Advertising Service @ KAIST
https://zabo.sparcs.org
MIT License
19 stars 7 forks source link

[Bug] dev deploy action 실패 시 기존 컨테이너 정지됨 #170

Closed withSang closed 1 year ago

withSang commented 1 year ago

Summary

It closes #169

아래 cd pipeline에서 docker pull 명령이 실패했을 때 다음 커맨드들이 계속 실행되어 기존 컨테이너가 종료되는 문제가 발생합니다. script_stop: true 옵션을 넣어 docker pull 명령이 실패했을 때 다음 커맨드들이 실행되지 않게 합니다.

      - name: executing remote ssh commands using password
        uses: appleboy/ssh-action@v1.0.0
        with:
          host: ${{ secrets.HOST }}
          port: ${{ secrets.PORT }}
          username: ${{ secrets.USERNAME }}
          password: ${{ secrets.PASSWORD }}
          proxy_host: ${{ secrets.PROXY_HOST }}
          proxy_port: ${{ secrets.PROXY_PORT }}
          proxy_username: ${{ secrets.PROXY_USERNAME }}
          proxy_password: ${{ secrets.PROXY_PASSWORD }}
++++++    script_stop: true  
          script: |
            docker pull ghcr.io/sparcs-kaist/zabo-front:dev
            docker rm -f zabo-front
            docker run --restart always -d -p 15081:80 --name zabo-front ghcr.io/sparcs-kaist/zabo-front:dev

Extra info

Images or Screenshots

Further Work

netlify[bot] commented 1 year ago

Deploy Preview for zabo-preview ready!

Name Link
Latest commit 0db20b559b3f96e1595287c87e4fc13ab6241b85
Latest deploy log https://app.netlify.com/sites/zabo-preview/deploys/650610ee1416470008807b4c
Deploy Preview https://deploy-preview-170--zabo-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.