sparhami / fstbh

Firefox addon that makes the top toolbar overlay the page rather than push it out of the way while in fullsecreen mode.
GNU General Public License v3.0
5 stars 1 forks source link

Pinned tabs get in the way #2

Open Philosoft opened 9 years ago

Philosoft commented 9 years ago

...whenever my mouse in left upper corener here i got screenshot of that pinned tabs issue

on that pic my mouse pointer lays just right above center of pinned tab, which gets highlighted and furthermore gets selected if i click here. why is that even an issue, when i use you glorious plugin in conjuction with vimperator? because that's the place where in google docs appears filename, and if i want to change it i either go to menu or to left upper corner to click on filename and edit it inplace.

sparhami commented 9 years ago

I tried to reproduce real quick white vimperator real quick on both Linux and Windows but couldn't. Could you give me a bit more information about your setup (OS, addon settings, when it occurs: fullscreen/maximized/non-maximized, etc.) that might help repoduce the issue?

Also, if you get a chance, can you confirm that is the interaction between the two add-ons by disabling all other add-ons and reproducing the issue?

Philosoft commented 9 years ago

of course.

ubuntu 14.10 (beta) amd64, awesome wm firefox 32.0; addons: adblock plus, vimperator, pocket, awesome screenshot. default addons setting in everyone except for vimperator (I change only hintchars in vimperatorrc). it occurs in every mode (maximized, fullscreen, non-maximized).

I can confirm that it reproduces every single time even with all addons except `toolbar autohide' being disabled.

Now, that I mentioned my wm, I'll try to reproduce it in unity.

Philosoft commented 9 years ago

I have tried it in unity. same thing

stevemcmillen commented 9 years ago

I see the same issue on Mac with latest Firefox. The pinned tabs prevent clicking that portion of the screen which can be a big problem if the web page has navigation elements in that location you need to get to.

I like to have about 5 pinned tabs for pages I regularly use. So this gets in the way a lot for me :(

sparhami commented 9 years ago

Let me take another look at this issue. It has been a while since I have worked on this add-on / add-on development in general, so my memory on how to do things is a bit fuzzy.

Just wondering, does this issue occur for you with vimperator as well? Does vimperator also have functionality for hiding toolbars? If so, is there any value to using toolbar autohide on top of vimperator?

stevemcmillen commented 9 years ago

I don't use vimperator (not sure what that is). I'll open a clean firefox profile and add our plugin and check if this still occurs.

stevemcmillen commented 9 years ago

This does not occur on a clean new profile but oddly if I disable every plugin I have (disable mind you, not delete), it still occurs. So I guess it must somehow be result of incompatibility between addons, I just don't know which. Note: I am using the default firefox theme.

So I guess the priority of this issue is pretty low. I can always find a workaround like not autohide for tabs.

sparhami commented 9 years ago

Could it be a browser preference? Also, one source of hard to reproduce bugs is that two addons that interact with the same parts of the browser code will have different behavior depending on the order that they were initially installed.

stevemcmillen commented 9 years ago

I stumbled upon a fix but I don't know why it fixes it. It seems if I add userChrome.css (even an empty one), the issue no longer occurs. I then remove the file and the issue is back. I was doing this as an attempt to workaround the issue by making the tab height smaller and thus

.tabbrowser-tabs *|tab { height: 12px !important; min-width: 8px !important }

Thanks for your help.